NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Intl] Update slack-emoji.php#49145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

adnen-chouibi wants to merge1 commit intosymfony:6.2fromadnen-chouibi:patch-1

Closed

[Intl] Update slack-emoji.php#49145

adnen-chouibi wants to merge1 commit intosymfony:6.2fromadnen-chouibi:patch-1

Conversation

Copy link

Contributor

adnen-chouibi commentedJan 29, 2023•
edited by nicolas-grekas
Loading

Q	A
Branch?	6.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	no
License	MIT
Doc PR	no

Personally, I use this file to transform country code to flag, I propose to use the same structure for all flags :flag-countryCode: , and to cover also all flags emoji

Update slack-emoji.php

050c09d

Personally, I use this file to transform country code to flag, I propose to use the same structure for all flags :flag-countryCode:  , and to cover also all flags emoji

carsonbot added Status: Needs Review Bug labels

Jan 29, 2023

carsonbot added this to the6.2 milestone

Jan 29, 2023

Copy link

carsonbot commentedJan 29, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedJan 29, 2023

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

derrabus added the Intl label

Jan 29, 2023

carsonbot changed the title~~Update slack-emoji.php~~[Intl] Update slack-emoji.php

Jan 29, 2023

Copy link

Member

nicolas-grekas commentedJan 29, 2023

This file is built by theResources/emoji/build.php file in the component. Can you please update it so that the next time we run the script, we don't loose your changes?