NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpFoundation] Fix bad return type in IpUtils::checkIp4()#49141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromtristankretzer:fix_ipUtils_checkIp4

Jan 29, 2023

Merged

[HttpFoundation] Fix bad return type in IpUtils::checkIp4()#49141

nicolas-grekas merged 1 commit intosymfony:5.4fromtristankretzer:fix_ipUtils_checkIp4

Jan 29, 2023

Conversation

Copy link

Contributor

tristankretzer commentedJan 27, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	see below
License	MIT
Doc PR	-

filter_var returns the value if it passes the applied filters. This leads toIpUtils::checkIp4() returning the address part of the CIDR notation (instead oftrue which is expected) if it is a valid IPv4 address with subnet mask 0.

This change fixes this behaviour.

carsonbot added Status: Needs Review Bug HttpFoundation labels

Jan 27, 2023

carsonbot added this to the5.4 milestone

Jan 27, 2023

carsonbot changed the title~~[httpFoundation] Fix bad return type in IpUtils::checkIp4()~~[HttpFoundation] Fix bad return type in IpUtils::checkIp4()

Jan 27, 2023

Copy link

carsonbot commentedJan 27, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot