Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] Fix collecting data non-late for the profiler#49104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
silverbackdan commentedJan 25, 2023
Really sorry but I do have gaps in my knowledge on how I bring in this change into my application to test the fix. I'm using the latest Symfony version, would you be find enough to let me know how to bring the change into my application and I'll run my tests again. |
nicolas-grekas commentedJan 25, 2023
The easiest way might be to just replace the file in your vendor directory by copy/pasting the one attached to this PR. |
silverbackdan commentedJan 25, 2023
Thanks@nicolas-grekas but I'm afraid the problem still persists |
silverbackdan commentedJan 25, 2023
I've done some dumping in the function and I think the issue is that with either of the new updates, the function is called twice. I can confirm that reverting just this file back to the previous version causes no issues so it is related to this change. |
silverbackdan commentedJan 25, 2023
|
silverbackdan commentedJan 25, 2023
Sorry for many messages and deleted ones. In the profiler listener In my case I seem to have requests for these. So perhaps in my code somewhere I am performing a sub-request which means that the trace would be cleared? |
nicolas-grekas commentedJan 25, 2023
No worries :) |
silverbackdan commentedJan 25, 2023
Looks like it works :) |
silverbackdan commentedJan 25, 2023
Will this be in 6.2.6? I'll leave a conflict in my composer for 6.2.5 just so I don't get failing tests :) |
nicolas-grekas commentedJan 25, 2023
Of course :) |
silverbackdan commentedJan 25, 2023
Thanks as always@nicolas-grekas |
amalricBzh commentedFeb 13, 2023
Hello,
But with http-client 5.4.20 wich include this PR => It's KO, the web profiler doesn't collect any HTTP Client calls, the "Http Client" tab is empty 😢 . |
fancyweb commentedFeb 13, 2023
Hello, it has been fixed in#49301. The patch should be released at the end of the month. |
@silverbackdan@pforesi could you please confirm that this fixes both your use cases?