Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Mention the transport which failed during the setup command#49044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromthePanz:messenger-mention-transport-failing-to-setup
Oct 6, 2023
Merged

[Messenger] Mention the transport which failed during the setup command#49044

fabpot merged 1 commit intosymfony:6.4fromthePanz:messenger-mention-transport-failing-to-setup
Oct 6, 2023

Conversation

@thePanz
Copy link
Contributor

@thePanzthePanz commentedJan 20, 2023•
edited by fabpot
Loading

The transport name can help to further investigate the underlying reasons of the failure

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Ticketsnone
LicenseMIT
Doc PR-

I am not sure if this can be labelled as a new feature, but the addition from this PR can help to further investigate errors while setting up an application's transports.

At the moment, if an error occurs while setting up a transport just the exception is thrown, with no context on which transport was being setup.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features / 5.4, 6.0, 6.1, or 6.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@thePanzthePanz changed the base branch from6.3 to5.4January 20, 2023 14:18
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a new feature, so please target6.3, thanks

@thePanzthePanz changed the base branch from5.4 to6.3January 20, 2023 14:59
@thePanzthePanz requested review fromOskarStark and removed request forchalasr,dunglas,lyrixx,wouterj,xabbuh andycerutoJanuary 20, 2023 14:59
@thePanz
Copy link
ContributorAuthor

This is a new feature, so please target6.3, thanks

OK, thanks for clarifying 👍 (sad that we're still on sf v5.4 😭 )

@thePanz
Copy link
ContributorAuthor

@OskarStark thanks for reviewing.

I guess the failed CIs are not due to this PR (pSaml and appveyor reports errors not related to the messenger component)

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGMT, I just have minor notes.

The transport name can help to further investigate the underlying reasons of the failure
@thePanzthePanz requested review fromOskarStark andnicolas-grekas and removed request forOskarStark andnicolas-grekasFebruary 14, 2023 14:51
@thePanzthePanz requested review fromOskarStark andnicolas-grekas and removed request forOskarStark andnicolas-grekasFebruary 14, 2023 14:52
@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.4May 23, 2023
@fabpot
Copy link
Member

Thank you@thePanz.

@thePanz
Copy link
ContributorAuthor

Thanks@fabpot for merging!

@thePanzthePanz deleted the messenger-mention-transport-failing-to-setup branchOctober 12, 2023 16:07
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStark

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@thePanz@carsonbot@fabpot@nicolas-grekas@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp