Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add #[\SensitiveParameter] to $sessionId#49016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.3frommfb:sensitive-param-session-id
Jan 19, 2023

Conversation

@mfb
Copy link
Contributor

@mfbmfb commentedJan 17, 2023
edited
Loading

QA
Branch?6.3
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Follow-up to#48274 and#46183

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very good idea, session ids are indeed sensitive data as stated by owasp:https://cheatsheetseries.owasp.org/cheatsheets/Session_Management_Cheat_Sheet.html

@mfb
Copy link
ContributorAuthor

mfb commentedJan 18, 2023

The suggested code style fix athttps://fabbot.io/patch/symfony/symfony/49016/32c9f28bebe3573431644838db625ef941f5405b/cs.diff looks wrong - I don't think I should remove a blank line just because I added an attribute to the function arguments. Icould not add it in those places, given this is just an abstract class, but seemed helpful for developers to have it there too.

@stof
Copy link
Member

Those blank line removals indeed look like a bug in php-cs-fixer (maybe a fixer is not handling attributes on parameters properly)

@nicolas-grekas
Copy link
Member

Thank you@mfb.

@nicolas-grekasnicolas-grekas merged commit107be18 intosymfony:6.3Jan 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@GromNaNGromNaNGromNaN approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

6 participants

@mfb@carsonbot@stof@nicolas-grekas@javiereguiluz@GromNaN

[8]ページ先頭

©2009-2025 Movatter.jp