NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Move Http clients data collecting at a late level#48898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4frompforesi:ticket_48894_fix_HttpClientDataCollector

Jan 9, 2023

Merged

[HttpClient] Move Http clients data collecting at a late level#48898

fabpot merged 1 commit intosymfony:5.4frompforesi:ticket_48894_fix_HttpClientDataCollector

Jan 9, 2023

Conversation

Copy link

Contributor

pforesi commentedJan 6, 2023

This allows to collect http clients data when sending them in a StreamedResponse callback method

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#48894
License	MIT
Doc PR

When a controller action is returning a StreamedResponse doing some HttpClient requests, http clients data are collected to early, so the Web profiler HttpClient panel is wrongly empty.
To fix this we moved data collecting to the HttpClientDataCollector::lateCollect() method which is called on ther kernel.terminate event.

carsonbot added Status: Needs Review Bug HttpClient labels

Jan 6, 2023

carsonbot added this to the5.4 milestone

Jan 6, 2023

Copy link

carsonbot commentedJan 6, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot