Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Fix for resolving Constraint Validator FQCN defined as %foo.bar.class% parameters#48846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@gassan
Copy link
Contributor

@gassangassan commentedJan 1, 2023•
edited
Loading

For exampleSymfony\Bridge\Doctrine\Validator\Constraints\UniqueEntityValidator is defined as%doctrine.orm.validator.unique.class% and must be properly resolved.

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@gassangassan changed the base branch from6.3 to6.2January 1, 2023 13:39
@gassangassanforce-pushed theresolve-validator-class-given-as-parameter branch from1de47b6 to991aed9CompareJanuary 1, 2023 13:53
@gassangassan changed the title[Translation] Fix for resolving validator class names defined as %foo.bar.class% parameters[Translation] Fix for resolving Constraint Validator FQCN defined as %foo.bar.class% parametersJan 1, 2023
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a test that covers your change.

@derrabus
Copy link
Member

Is this bug present in Symfony 6.2 only or is 5.4 affected as well?

@gassangassanforce-pushed theresolve-validator-class-given-as-parameter branch from991aed9 to802ed1eCompareJanuary 1, 2023 20:59
@gassangassanforce-pushed theresolve-validator-class-given-as-parameter branch from802ed1e toc965b03CompareJanuary 1, 2023 21:35
@gassan
Copy link
ContributorAuthor

Is this bug present in Symfony 6.2 only or is 5.4 affected as well?

I think it is an S6.2 enhancement for extracting/.*message/i from Entity Attributes.

@derrabus
Copy link
Member

Right, this piece of code has been introduced with#46161.

@fabpot
Copy link
Member

Thank you@gassan.

@fabpotfabpot merged commit20851ea intosymfony:6.2Jan 5, 2023
@gassangassan deleted the resolve-validator-class-given-as-parameter branchJanuary 5, 2023 09:28
@fabpotfabpot mentioned this pull requestJan 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

@welcoMatticwelcoMatticAwaiting requested review from welcoMattic

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@gassan@carsonbot@derrabus@fabpot@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp