In some apps, you might use an expression as the value of someTranslatableMessage object. The result of this expression can result in using an empty string as the value of the that object:

newTranslatableMessage($someCondition ?$someObject->someMethod() :'')

The issue is that Symfony will report that empty string in the list of "missing translations" (like in the first row of this image):

I think this is a bug and an empty string should just be output "as is" without reporting it as missing.

What do you think? Is this truly a bug? Would it be a new feature for 6.3? The current behavior is correct and we should close without merging? Thanks.

javiereguiluz added the Translation label

Dec 30, 2022

javiereguiluz added this to the5.4 milestone

Dec 30, 2022

carsonbot added Status: Needs Review Bug labels

Dec 30, 2022

Copy link

carsonbot commentedDec 31, 2022

Hey!

I think@rvanlaak has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link

Contributor

maxbeckers commentedJan 10, 2023•
edited
Loading

Hi@javiereguiluz,

i can't reproduce the problem. When I translate{{ 'invalid'|trans }}, then i get one message for missing Translation. When I translate{{ ''|trans }} then there is no message.

Tried with a clean symfony 5.4 and 6.1 environment.

UPDATE
I can reproduce with setting this in controller['test' => new TranslatableMessage(''),] and then{{ test|trans }}. Sorry, didn't read the issue correlctly. Then I'm fine with the fix :) And yes for me it's as well a kind of bugfix, so I'm fine with 5.4.

maxbeckers approved these changes

Jan 10, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 10, 2023

Copy link

Member

nicolas-grekas commentedJan 11, 2023•
edited
Loading

Why don't you use this code instead?

$someCondition ?newTranslatableMessage($someObject->someMethod()) :''

It would make more sense to me. Why wrap the empty string in a translatable when it's not translatable content?

Copy link

MemberAuthor

javiereguiluz commentedJan 17, 2023•
edited
Loading

Looking at Twig Bridgetrans() function, I think there's an inconsistency:

symfony/src/Symfony/Bridge/Twig/Extension/TranslationExtension.php

Lines 99 to 122 in1f7bc10

	publicfunctiontrans(string\|\Stringable\|TranslatableInterface\|null$message,array\|string$arguments = [],string$domain =null,string$locale =null,int$count =null):string
	{
	if ($messageinstanceof TranslatableInterface) {
	if ([] !==$arguments && !\is_string($arguments)) {
	thrownew \TypeError(sprintf('Argument 2 passed to "%s()" must be a locale passed as a string when the message is a "%s", "%s" given.',__METHOD__, TranslatableInterface::class,get_debug_type($arguments)));
	}

	return$message->trans($this->getTranslator(),$locale ?? (\is_string($arguments) ?$arguments :null));
	}

	if (!\is_array($arguments)) {
	thrownew \TypeError(sprintf('Unless the message is a "%s", argument 2 passed to "%s()" must be an array of parameters, "%s" given.', TranslatableInterface::class,__METHOD__,get_debug_type($arguments)));
	}

	if ('' ===$message = (string)$message) {
	return'';
	}

	if (null !==$count) {
	$arguments['%count%'] =$count;
	}

	return$this->getTranslator()->trans($message,$arguments,$domain,$locale);
	}