NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[CssSelector] add support for :is() and :where()#48803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.1fromJean-Beru:css-selector/add-is-and-where

Feb 3, 2024

Merged

[CssSelector] add support for :is() and :where()#48803

fabpot merged 1 commit intosymfony:7.1fromJean-Beru:css-selector/add-is-and-where

Feb 3, 2024

Conversation

Copy link

Contributor

Jean-Beru commentedDec 28, 2022•
edited by fabpot
Loading

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix#48772
License	MIT
Doc PR	symfony/symfony-docs#17628

This PR adds support for:is() and:where() pseudo-classes.

carsonbot added Status: Needs Review CssSelector Feature labels

Dec 28, 2022

carsonbot added this to the6.3 milestone

Dec 28, 2022

Jean-Beru mentioned this pull request

Dec 28, 2022

[CssSelector] add support for :is() and :where()symfony/symfony-docs#17628

Merged

Jean-Beru force-pushed thecss-selector/add-is-and-where branch fromf2d4128 tod1d438dCompare

December 28, 2022 12:43

OskarStark reviewed

Dec 30, 2022

View reviewed changes

src/Symfony/Component/CssSelector/CHANGELOG.md OutdatedShow resolvedHide resolved

src/Symfony/Component/CssSelector/Node/MatchingNode.php OutdatedShow resolvedHide resolved

Jean-Beru force-pushed thecss-selector/add-is-and-where branch 2 times, most recently fromd56aef3 tob71d1b6Compare

December 30, 2022 16:00

Copy link

Member

fabpot commentedDec 30, 2022

You should rebase instead of merging 6.3

Jean-Beru force-pushed thecss-selector/add-is-and-where branch 2 times, most recently from8872ef6 to26eefb3Compare

December 30, 2022 16:31

Copy link

ContributorAuthor

Jean-Beru commentedDec 30, 2022

My bad, I used the GitHub UI to resolve conflicts 🤦‍♂️

fabpot requested changes

Dec 30, 2022

View reviewed changes

src/Symfony/Component/CssSelector/CHANGELOG.md OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Dec 30, 2022

fancyweb reviewed

Dec 30, 2022

View reviewed changes

src/Symfony/Component/CssSelector/Node/MatchingNode.php OutdatedShow resolvedHide resolved

fancyweb reviewed

Jan 3, 2023

View reviewed changes

src/Symfony/Component/CssSelector/XPath/XPathExpr.php OutdatedShow resolvedHide resolved

stof requested changes

Jan 3, 2023

View reviewed changes

src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php OutdatedShow resolvedHide resolved

src/Symfony/Component/CssSelector/Node/MatchingNode.phpShow resolvedHide resolved

stof requested changes

Jan 4, 2023

View reviewed changes

src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php OutdatedShow resolvedHide resolved

src/Symfony/Component/CssSelector/XPath/XPathExpr.php OutdatedShow resolvedHide resolved

src/Symfony/Component/CssSelector/Parser/Parser.php OutdatedShow resolvedHide resolved

stof mentioned this pull request

Jan 4, 2023

The specificity computation is wrong for :where and :isscrapy/cssselect#136

Open

Jean-Beru force-pushed thecss-selector/add-is-and-where branch from23ed186 tof22bf69Compare

March 2, 2023 08:02

OskarStark requested a review fromfancyweb

March 2, 2023 09:22

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Mar 2, 2023

OskarStark requested a review fromstof

March 2, 2023 09:22

Jean-Beru force-pushed thecss-selector/add-is-and-where branch 3 times, most recently from4a39386 tob262a86Compare

March 27, 2023 07:08

Jean-Beru force-pushed thecss-selector/add-is-and-where branch fromb262a86 to4b70ca5Compare

April 27, 2023 12:51

Copy link

ContributorAuthor

Jean-Beru commentedApr 27, 2023

@stof Reviews have been resolved. Is there anything to change ?

nicolas-grekas modified the milestones:6.3,6.4

May 23, 2023

Jean-Beru force-pushed thecss-selector/add-is-and-where branch from4b70ca5 to752f921Compare

July 27, 2023 14:07

Copy link

ContributorAuthor

Jean-Beru commentedJul 27, 2023

I rebased this PR to 6.4.

Should I keep it opened ?

OskarStark requested a review fromfabpot

July 28, 2023 05:47

Copy link

Contributor

OskarStark commentedJul 28, 2023

Friendly ping@stof @fabpot as you had some comments

stloyd reviewed

Jul 28, 2023

View reviewed changes

src/Symfony/Component/CssSelector/CHANGELOG.md OutdatedShow resolvedHide resolved

fabpot requested changes

Aug 1, 2023

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some random CS suggestions.

src/Symfony/Component/CssSelector/Node/MatchingNode.php OutdatedShow resolvedHide resolved

src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 1, 2023

nicolas-grekas modified the milestones:6.4,7.1

Nov 15, 2023

fabpot approved these changes

Feb 3, 2024

View reviewed changes

src/Symfony/Component/CssSelector/CHANGELOG.md Outdated

		CHANGELOG
		=========

		6.4

Copy link

Member

fabpotFeb 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	6.4
	7.1

src/Symfony/Component/CssSelector/CHANGELOG.md Outdated

		=========

		6.4
		-----

Copy link

Member

fabpotFeb 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	-----
	---

src/Symfony/Component/CssSelector/Node/SpecificityAdjustmentNode.phpShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Feb 3, 2024

[CssSelector] add support for :is() and :where()

c083e1d

fabpot force-pushed thecss-selector/add-is-and-where branch fromc483f62 toc083e1dCompare

February 3, 2024 17:46

Copy link

Member

fabpot commentedFeb 3, 2024

Thank you@Jean-Beru.

fabpot merged commitd2d36b5 intosymfony:7.1

Feb 3, 2024

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request

Feb 5, 2024

minor#17628[CssSelector] add support for :is() and :where() (Jean-B…

c56ca52

…eru)This PR was submitted for the 6.4 branch but it was merged into the 7.1 branch instead.Discussion----------[CssSelector] add support for :is() and :where()Add documentation for*symfony/symfony#48803Commits-------f61c919 [CssSelector] add support for :is() and :where()

Jean-Beru deleted the css-selector/add-is-and-where branch

March 21, 2024 15:58

fabpot mentioned this pull request

May 2, 2024

Release v7.1.0-BETA1#54820

Merged