Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove calls toAnnotationRegistry::registerLoader()#48725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@derrabus
Copy link
Member

QA
Branch?6.3
Bug fix?no
New feature?no
Deprecations?yes
TicketsN/A
LicenseMIT
Doc PRN/A

CallingAnnotationRegistry::registerLoader() should not be necessary anymore since Annotations 1.10 (April 2020), as long as all annotations are autoloadable. Let's remove all calls to that method.

@derrabus
Copy link
MemberAuthor

derrabus commentedDec 20, 2022•
edited
Loading

Technically, we could do this on 5.4 already becauseAnnotationRegistry::registerLoader('class_exists'); should be a no-op and we already have conflict rules for Annotations < 1.10 in place. Let me know if you think I should backport the change.

The low-deps tests showed me that we should not backport. Registeringclass_exists as loader is still necessary, if someone somewhere calls (the also deprecated)AnnotationRegistry::registerFile(). Removing our only call to that method required me to bump the ORM to >= 2.12.

We cannot anticipate if a codebase still has thatAnnotationRegistry::registerFile() call somewhere, so we might as well decide to not merge this change as long as we support Annotations v1.

@derrabusderrabusforce-pushed theimprovement/remove-annotation-loader branch from28a7226 tocaf16edCompareDecember 20, 2022 19:54
@nicolas-grekasnicolas-grekasforce-pushed theimprovement/remove-annotation-loader branch from066d851 toc0e9ee1CompareDecember 22, 2022 14:39
@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekas
Copy link
Member

I reverted the part about phpunit-bridge in9f5c005

@derrabus
Copy link
MemberAuthor

Fair enough, but the ORM bump in the root composer.json was still legit. Why did you revert it as well?

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedDec 28, 2022•
edited
Loading

By mistake, let me fix that.
Fixed in6d3b3f1

@derrabus
Copy link
MemberAuthor

Thanks!

bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestJan 9, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestJan 9, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestJan 9, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestJan 9, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestJan 9, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestFeb 15, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestFeb 15, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestFeb 15, 2023
bitgandtter pushed a commit to timgchile/symfony that referenced this pull requestFeb 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

4 participants

@derrabus@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp