NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] Revert "bug #48089 Fix clear line with question in section (maxbeckers)#48681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.1fromchalasr:revert-48089

Dec 16, 2022

Merged

[Console] Revert "bug #48089 Fix clear line with question in section (maxbeckers)#48681

nicolas-grekas merged 1 commit intosymfony:6.1fromchalasr:revert-48089

Dec 16, 2022

Conversation

Copy link

Member

chalasr commentedDec 16, 2022

This reverts commitcaffee8, reversing changes made tof14901e.

Q	A
Branch?	6.1
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	/
License	MIT
Doc PR	-

The tests added in#48089 break on branch 6.2, and after checking the fix on both 6.1 and 6.2 based on the reproducer from#47411, I feel like the behavior is still not the expected one.
I propose to revert for now, hope we can fix this bug homogeneously in another PR.

Revert "bugsymfony#48089[Console] Fix clear line with question in s…

30caa8d

…ection (maxbeckers)"This reverts commitcaffee8, reversingchanges made tof14901e.

carsonbot added Status: Needs Review Bug Console labels

Dec 16, 2022

carsonbot added this to the6.1 milestone

Dec 16, 2022

carsonbot changed the title~~Revert "bug #48089 [Console] Fix clear line with question in section (maxbeckers)~~[Console] Revert "bug #48089 Fix clear line with question in section (maxbeckers)

Dec 16, 2022