Movatterモバイル変換

carsonbot added this to the6.2 milestone

nikophil commented

src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php

		$params = [];
		foreach ($constructorParametersas$constructorParameter) {
		$paramName =$constructorParameter->name;
		$attributeContext =$this->getAttributeDenormalizationContext($class,$paramName,$context);

Copy link

ContributorAuthor

nikophilDec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

heregetAttributeDenormalizationContext() was getting passed$key which represents the serializedName, although we want the name of the property, to access its metadata

nicolas-grekas reviewed

src/Symfony/Component/Serializer/Tests/Normalizer/Features/ObjectDummyWithContextAttribute.php OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

src/Symfony/Component/Serializer/Tests/Normalizer/Features/ObjectDummyWithContextAttribute.php OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php OutdatedShow resolvedHide resolved

Copy link

Contributor

mtarld commentedDec 15, 2022•
edited
Loading

It is quite strange that it do the exact opposite of what#46847 does

Copy link

Member

nicolas-grekas commentedDec 15, 2022

Let's add a test case that covers the target behavior in#46847, this might help sort this out.

Copy link

ContributorAuthor

nikophil commentedDec 15, 2022•
edited
Loading

@nicolas-grekas code style fixed 👍

I'm not sure what else to test.#46847 says:

I realized we can't use the Context attribute context in anAdvancedNameConverterInterface::denormalize()

but we only pass throughAdvancedNameConverterInterface::normalize() here.

And the PR mentions#46525 which says:

Property specific denormalization context doesn't work when property name in the array being denormalized is different from property name in the class.

which is exactly what my PR does and tests...

[Serializer] fix context attribute with serializedName

c87ac90

dunglas approved these changes

Copy link

Member

dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

carsonbot added Status: Reviewed and removed Status: Needs Review labels

mtarld approved these changes

ogizanagi approved these changes