NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Dotenv] Handle dynamic variables in multiple .env files#48636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

valx76 wants to merge6 commits intosymfony:7.4

base:7.4

Choose a base branch

fromvalx76:fix_multi_env_dynamic_var

Open

[Dotenv] Handle dynamic variables in multiple .env files#48636

valx76 wants to merge6 commits intosymfony:7.4fromvalx76:fix_multi_env_dynamic_var

+196 −16

Conversation

Copy link

valx76 commentedDec 13, 2022•
edited
Loading

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#40717
License	MIT
Doc PR	-

This fixes the dynamic variables not using thefinal value of a property.
It handles only one level of dynamicity (e.g. we can't havevar->var->const, onlyvar->const).

The process is basically to have two passes when reading the .env files; the first one is to parse constants and the second one is to resolve variables using the calculated values.
It will also remove the need to care about the variables' order (if this gets accepted, there would be a change needed in the documentation onthis page).

I would like some feedback (first contribution and currently learning the framework), mostly on teloadEnv() function, since@nicolas-grekas was talking about a possiblewon't fix status for this in issue#40717.

Added dynamic multi .env file config

e7c9e4a

carsonbot added Status: Needs Review Bug Dotenv labels

Dec 13, 2022

carsonbot added this to the6.3 milestone

Dec 13, 2022

Copy link

carsonbot commentedDec 13, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot