Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ExpressionLanguage] Fix BC of cached SerializedParsedExpression containing GetAttrNode#48559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| publicfunction__unserialize(array$data):void | ||
| { | ||
| $this->nodes =$data['nodes']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas I'm wondering if there's a way to just call the "default PHP unserialization" in one line and then add the extra checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use __wakeup instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
on a closer look, the code is correct (except for isNullCoalesce which has never been part of any serialized payloads)
fsevestre commentedDec 9, 2022
Hello, I can confirm that with the current patch my error is gone 👍 |
fb817ee to6c33582Comparenicolas-grekas commentedDec 13, 2022
Thank you@fancyweb. |
Ref#47058
GetAttrNodecan be serialized and cached throughSerializedParsedExpression.@fsevestre Can you try this small patch plz?