Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Fix rendered templates for notifications#48505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ThomasTr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works for me
9501407 to87276fbComparexabbuh commentedDec 6, 2022
looks like we need to bump the minimum allowed version of |
87276fb toba1bd59CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
46d2f8a tobf9aea9Compare| if (4 ===\count($data)) { | ||
| [$this->context,$this->theme,$this->rendered,$parentData] =$data; | ||
| }elseif (3 ===\count($data)) { | ||
| [$this->context,$this->theme,$parentData] =$data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is worth adding a comment as done two lines below or should it be updated to cover this new case?
| publicfunctionisRendered():bool | ||
| { | ||
| returnnull ===$this->htmlTemplate &&null ===$this->textTemplate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not using a boolean property as done in the other class?
Setting those tonull in the next method could lead to inconsistency?
bf9aea9 to677e188Compare677e188 to085185dCompare| $message =$event->getMessage(); | ||
| if ($messageinstanceof TemplatedEmail &&($message->getTextTemplate() ||$message->getHtmlTemplate())) { | ||
| if ($messageinstanceof TemplatedEmail &&!$message->isRendered()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The behavior seems different here now, the error may be that the template has already been rendered.
Alternative to#48481