Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] FixContainerBuilder stats env usage with enum#48502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alamirault
Copy link
Contributor

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#48498
LicenseMIT
Doc PRsymfony/symfony-docs#...

Without patch:

['enum:Symfony\Component\DependencyInjection\Tests\Fixtures\StringBackedEnum:foo' =>0,'Bar' =>1,]

With patch:

['enum:Symfony\Component\DependencyInjection\Tests\Fixtures\StringBackedEnum:foo' =>1,'Bar' =>1,]

@carsonbotcarsonbot added this to the6.2 milestoneDec 5, 2022
@OskarStarkOskarStark changed the title[DependencyInjection] Fix ContainerBuilder stats env usage with enum[DependencyInjection] FixContainerBuilder stats env usage with enumDec 5, 2022
Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the test.
For reviewers, this regex was introduced by#47176

alamirault reacted with thumbs up emoji
Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The regex is also inMergeExtensionConfigurationPass.

@nicolas-grekas
Copy link
Member

Looking why we forgot that in#46564, I think the correct patch is to add\\ to the strtr on this line:
https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/DependencyInjection/ParameterBag/EnvPlaceholderParameterBag.php#L52

@nicolas-grekasnicolas-grekasforce-pushed thehotfix/48498-fix-env-couting-enum branch frome70a80a to75da869CompareDecember 6, 2022 17:09
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(I implemented the change I suggested)

@nicolas-grekas
Copy link
Member

Thank you@alamirault.

@nicolas-grekasnicolas-grekas merged commitee94cc9 intosymfony:6.2Dec 6, 2022
@fabpotfabpot mentioned this pull requestDec 6, 2022
@alamirault
Copy link
ContributorAuthor

(I implemented the change I suggested)

Thanks Nicolas 😄

@alamiraultalamirault deleted the hotfix/48498-fix-env-couting-enum branchDecember 6, 2022 18:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@GromNaNGromNaNGromNaN approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

4 participants

@alamirault@nicolas-grekas@GromNaN@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp