Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] Use same color as other icons for the close toolbar btn#48476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromogizanagi:profiler-close-btn
Dec 6, 2022

Conversation

@ogizanagi
Copy link
Contributor

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

Same color assf-toolbar-icon, which has better contrast:

BeforeAfter
SCR-20221205-dsiSCR-20221205-dpf-2

@javiereguiluz
Copy link
Member

@ogizanagi where does this happen to you? On macOS + Chrome or Firefox I see the close button with the right color without having to do this change:

close-button

And the color is maintained when hovering the mouse pointer:

close-button-in-action

@ogizanagi
Copy link
ContributorAuthor

@javiereguiluz : It happens to me and a teammate, with Symfony 6.2.0 using on macOS + Chrome 108.0.5359.71, Firefox and Safari as well 🤔

@javiereguiluz
Copy link
Member

It's strange that I don't see this issue when using the same browser + OS.

In any case, your contribution is perfect and it doesn't hurt at all to define the color explicitly. So, let's merge this. Thanks!

@ogizanagi
Copy link
ContributorAuthor

ogizanagi commentedDec 5, 2022•
edited
Loading

To complete, here is what shows the Chrome inspector on the<svg> element:

SCR-20221205-o9m

SCR-20221205-o8r

@javiereguiluz
Copy link
Member

Thanks for sharing this. Now I know what happened ... theapp.css file of my apps apply acolor: inherit to certain form elements. That's the difference with your app and that's why I couldn't see this issue while working on the redesign 🙈

inspector-svg-element

ogizanagi reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@ogizanagi.

@fabpotfabpot merged commit2b292e7 intosymfony:6.2Dec 6, 2022
@ogizanagiogizanagi deleted the profiler-close-btn branchDecember 6, 2022 13:13
@fabpotfabpot mentioned this pull requestDec 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@stofstofstof approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

+2 more reviewers

@benji07benji07benji07 approved these changes

@maxbeckersmaxbeckersmaxbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

8 participants

@ogizanagi@javiereguiluz@fabpot@benji07@stof@welcoMattic@maxbeckers@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp