Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Fix casing of getCurrentRoute/getCurrentRouteParameters methods#48434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromKocal:fix/twig-bridge-route-methods
Dec 2, 2022
Merged

[TwigBridge] Fix casing of getCurrentRoute/getCurrentRouteParameters methods#48434

fabpot merged 1 commit intosymfony:6.2fromKocal:fix/twig-bridge-route-methods
Dec 2, 2022

Conversation

@Kocal
Copy link
Member

@KocalKocal commentedDec 1, 2022•
edited
Loading

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PR-

Following of#47535, those two methods were named like this in order to getapp.current_route andapp.current_route_parameters, however PHPStorm autocomplete forapp.current_Route andapp.current_Route_Parameters.

I'm not sure if this is a PHPStorm-only issue or not.

Before:
image

After:
image

HeahDude reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3 for features / 5.4, 6.0, 6.1, or 6.2 for bug fixes ".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@KocalKocal changed the title[TwigBridge] Fix casing of currentRoute/currentRouteParameters methods[TwigBridge] Fix casing of getCurrentRoute/getCurrentRouteParameters methodsDec 1, 2022
@KocalKocal marked this pull request as draftDecember 1, 2022 23:12
@KocalKocal marked this pull request as ready for reviewDecember 1, 2022 23:12
@Kocal
Copy link
MemberAuthor

Well, looks like I broke Carson... 😬

@fabpot
Copy link
Member

Thank you@Kocal.

@fabpotfabpot merged commit3444c1e intosymfony:6.2Dec 2, 2022
@KocalKocal deleted the fix/twig-bridge-route-methods branchDecember 2, 2022 09:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@Kocal@carsonbot@fabpot@javiereguiluz@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp