Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed undefined variable error#48428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.2fromWarriorXK:6.2
Dec 1, 2022
Merged

Fixed undefined variable error#48428

fabpot merged 1 commit intosymfony:6.2fromWarriorXK:6.2
Dec 1, 2022

Conversation

@WarriorXK
Copy link

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#48426
LicenseMIT
Doc PRn/a

Fixes an undefined variable warning during ZSH autocomplete if no suggestions have been provided.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@WarriorXK
Copy link
Author

I see that the unit tests failed on something that is unrelated, do I need to do something with this>

@fabpot
Copy link
Member

Good catch, thanks@WarriorXK.

@fabpotfabpot merged commitc2172e7 intosymfony:6.2Dec 1, 2022
@fabpotfabpot mentioned this pull requestDec 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@maxbeckersmaxbeckersmaxbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

6 participants

@WarriorXK@carsonbot@fabpot@stof@chalasr@maxbeckers

[8]ページ先頭

©2009-2025 Movatter.jp