Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Set manipulated message from event to original message#48393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
y4roc wants to merge1 commit intosymfony:4.4fromy4roc:issue-48221
Closed

[Mailer] Set manipulated message from event to original message#48393

y4roc wants to merge1 commit intosymfony:4.4fromy4roc:issue-48221

Conversation

@y4roc
Copy link

@y4rocy4roc commentedNov 29, 2022
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#48221
LicenseMIT

Set manipulated message from event to original message.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update thePR base branch to target one of these branches instead? 5.4, 6.0, 6.1, 6.2, 6.3.

Cheers!

Carsonbot

@y4rocy4roc changed the base branch from4.4 to5.4November 29, 2022 16:04
@derrabusderrabus modified the milestones:4.4,5.4Nov 29, 2022
@y4rocy4roc changed the titleIssue 48221[Mailer] Set manipulated message from event to original messageNov 29, 2022
@y4rocy4roc changed the base branch from5.4 to4.4November 29, 2022 16:21
@xabbuh
Copy link
Member

Hasn't this been already fixed by#47822?

@y4roc
Copy link
Author

Yes, this has been already fixed.

@y4rocy4roc closed thisNov 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@y4roc@carsonbot@xabbuh@derrabus

[8]ページ先頭

©2009-2025 Movatter.jp