Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add more #[\SensitiveParameter]#48274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| publicfunctionrefreshToken(#[\SensitiveParameter]string$tokenId):CsrfToken | ||
| publicfunctionrefreshToken(string$tokenId):CsrfToken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@GromNaN I think this one was a mistake. It was not added to the interface and all other CSRF token ids. WDYT?
| * Stores a CSRF token. | ||
| */ | ||
| publicfunctionsetToken(string$tokenId,string$token); | ||
| publicfunctionsetToken(string$tokenId,#[\SensitiveParameter]string$token); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
From#46183:
The attribute has no effect on the interface, but is a remainder for implementers.
GromNaN left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch.
fabpot commentedNov 22, 2022
Thank you@fancyweb. |
This PR was merged into the 6.3 branch.Discussion----------Add #[\SensitiveParameter] to $sessionId| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Follow-up to#48274 and#46183Commits-------32c9f28 Add #[\SensitiveParameter] to $sessionId
Follow-up to#46183