Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console]  Fix signal handlers called after event listeners and skip exit#48210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@GromNaN
Copy link
Member

@GromNaNGromNaN commentedNov 13, 2022•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#48205
LicenseMIT
Doc PR-

Restore registration of signal handlers after the event dispatcher.
https://github.com/symfony/symfony/pull/45333/files#diff-8f1fd83284712ab08cb5d391da70ea0e78719ef08db852596997a4085848a026L1009

@carsonbotcarsonbot added this to the5.4 milestoneNov 13, 2022
@carsonbotcarsonbot changed the title[Console] Fix signal handlers called after event listeners and skip exit[Console]  Fix signal handlers called after event listeners and skip exitNov 13, 2022
@nicolas-grekas
Copy link
Member

Thank you@GromNaN.

@nicolas-grekasnicolas-grekas merged commitb0e1f66 intosymfony:5.4Nov 14, 2022
@GromNaNGromNaN deleted the 5.4-signal-hander-after-event-listeners branchNovember 14, 2022 11:24
@fabpotfabpot mentioned this pull requestNov 19, 2022
@Naktibalda
Copy link
Contributor

This change causes Segmentation fault when Xdebug path coverage is enabled.

@Naktibalda
Copy link
Contributor

Naktibalda commentedNov 20, 2022•
edited
Loading

I really can't blame this change, because in my case$commandSignals is empty, butforeach call itself causes segmentation fault much further down the line. (Removingforeach solves my problem).

Also this change only causes segmentation fault when used in combination with Codeception 5 and PHPUnit's main branch.
I can't create smaller sample than this:https://github.com/Naktibalda/codeception-segfault
Xdebug bug reporthttps://bugs.xdebug.org/view.php?id=2108
Similar segmentation fault was caused and quickly fixed by moving signal code back in August.

GromNaN reacted with thumbs up emoji

@GromNaN
Copy link
MemberAuthor

GromNaN commentedNov 21, 2022•
edited
Loading

It might be possible to prevent this issue by wrapping theforeach in anif ($commandSignals) { ... } but that will not solve it when command signal are actually used.

This was referencedNov 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxlyrixx approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@GromNaN@nicolas-grekas@Naktibalda@lyrixx@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp