Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Add Pusher Notifier Bridge#48203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
bitgandtter wants to merge23 commits intosymfony:7.1fromtimgchile:pusher-notification

Conversation

@bitgandtter
Copy link
Contributor

@bitgandtterbitgandtter commentedNov 12, 2022
edited by OskarStark
Loading

QA
Branch?6.3
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PR

AddPusher symfony notifier bridge

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@OskarStarkOskarStark removed this from the6.2 milestoneNov 12, 2022
@bitgandtter
Copy link
ContributorAuthor

@OskarStark do I need to do something else?

@bitgandtterbitgandtter changed the title[Notifier] Add Pusher Notifier Bridge (WIP)[Notifier] Add Pusher Notifier BridgeNov 15, 2022
@bitgandtter
Copy link
ContributorAuthor

Hello. from fabpotbot

in Commits list, agit rebase is needed to remove any merges
Merge branch 'symfony:6.2' into pusher-notification
Merge branch 'symfony:6.3' into pusher-notification

excuse my ignorance what do I need to do with it?

thanks in advance

@fabpot
Copy link
Member

To fix fabpot, you will need to rebase your PR instead of merging the base branch.
Here is the relevant section of the docs that explain it:https://symfony.com/doc/current/contributing/code/pull_requests.html#rebase-your-pull-request

bitgandtterand others added16 commitsFebruary 15, 2023 13:37
chore: remove@internal annotation from testschore: add footer to README.mdchore: apply PR comments
@bitgandtter
Copy link
ContributorAuthor

let me know if this works@nicolas-grekas

feat: configure pusher notifier on framework bundle
fix: drop sensitive information from toString method on transport
@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.4May 23, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.4,7.1Nov 15, 2023
@OskarStark
Copy link
Contributor

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot requested changes

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@xabbuhxabbuhAwaiting requested review from xabbuh

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

7 participants

@bitgandtter@carsonbot@fabpot@nicolas-grekas@OskarStark@stof@derrabus

[8]ページ先頭

©2009-2025 Movatter.jp