Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Fix time-limit check exception#48198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alamirault
Copy link
Contributor

@alamiraultalamirault commentedNov 11, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#48196
LicenseMIT
Doc PRsymfony/symfony-docs#...

Check ontime-limit was invalid.

(Unrelated fabbot failure)

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "4.4" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

alamirault reacted with thumbs up emoji

Copy link
Contributor

@maxbeckersmaxbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch! And thanks for the test.

Please have a look at the fabbot.

@nicolas-grekas
Copy link
Member

Thank you@alamirault.

@nicolas-grekasnicolas-grekasforce-pushed thehotfix/48196-fix-messenger-consume-limit branch froma8b4ddb toa13b41aCompareNovember 14, 2022 09:53
@nicolas-grekasnicolas-grekas merged commit63221f0 intosymfony:4.4Nov 14, 2022
@fabpotfabpot mentioned this pull requestNov 19, 2022
This was referencedNov 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@maxbeckersmaxbeckersmaxbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@alamirault@carsonbot@nicolas-grekas@maxbeckers
[8]ページ先頭
©2009-2025 Movatter.jp