Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Routing] Fix PSR-4 directory loader for abstract classes#48170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
derrabus commentedNov 9, 2022
| Q | A |
|---|---|
| Branch? | 6.2 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#48168, Replaces#48169 |
| License | MIT |
| Doc PR | N/A |
nicolas-grekas commentedNov 9, 2022
Thank you@derrabus. |
stof commentedNov 9, 2022
shouldn't this also skip enums ? |
derrabus commentedNov 9, 2022
Enums don't cause an issue as far as I can tell. Shall I add one to the fixtures just in case? |
derrabus commentedNov 9, 2022
stof commentedNov 9, 2022
The fact that they don't have an issue is probably because the AnnotationClassLoader for the routing does not validate them (and so tries to load routes defined on them but it is unlikely to find some) |
derrabus commentedNov 9, 2022
Yes. Not sure what happens though if someone tried to add |
stof commentedNov 10, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Probably a WTF error when trying to instantiate the controller (unless that part takes care of giving a better error message). However, I'm fine with failing for such case, as there is no valid reason for that (while a route in an abstract class might make sense in some cases where you have a child class belong loaded as well) |
… (derrabus)This PR was merged into the 6.2 branch.Discussion----------[Routing] Make sure enums don't confuse the PSR-4 loader| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets |#48170 (comment)| License | MIT| Doc PR | N/ACommits-------6ae6af0 [Routing] Make sure enums don't confuse the PSR-4 loader