Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] Fix language deprecations incorrectly marked as direct#48122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromwouterj:fix-language-deprecation-types
Nov 11, 2022

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedNov 6, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

When using a vendor class that has a language deprecation (e.g. missing__serialize methods), these deprecations were incorrectly considered "direct".

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "4.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@wouterjwouterj changed the base branch from6.2 to4.4November 6, 2022 12:20
@wouterjwouterj modified the milestones:6.2,4.4Nov 6, 2022
@wouterjwouterjforce-pushed thefix-language-deprecation-types branch 2 times, most recently fromc874e8e todfac00aCompareNovember 6, 2022 12:58
@carsonbot
Copy link

Hey!

I think@michaelKaefer has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@wouterjwouterjforce-pushed thefix-language-deprecation-types branch fromdfac00a to481a8c7CompareNovember 8, 2022 14:40
@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commit2e3ffe2 intosymfony:4.4Nov 11, 2022
@wouterjwouterj deleted the fix-language-deprecation-types branchNovember 11, 2022 07:10
@fabpotfabpot mentioned this pull requestNov 19, 2022
This was referencedNov 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@maxbeckersmaxbeckersmaxbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@wouterj@carsonbot@fabpot@maxbeckers
[8]ページ先頭
©2009-2025 Movatter.jp