Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Compare cookie with null value as empty string in ResponseCookieValueSame#48112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromfancyweb:http-foundation/fix-response-cookie-value-same-null-cookie-valueNov 5, 2022
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…sponseCookieValueSame
stof approved these changesNov 4, 2022
werwolf666 commentedNov 4, 2022
Good decision. Thank you. |
maxbeckers approved these changesNov 5, 2022
Member
nicolas-grekas commentedNov 5, 2022
Thank you@fancyweb. |
Merged
This was referencedNov 28, 2022
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already consider
nullas''when we "compute" the cookie:symfony/src/Symfony/Component/HttpFoundation/Cookie.php
Line 253 in4d4c411
So in the related issue,
self::assertResponseCookieValueSame('SOME_COOKIE_NAME', '');could be used. WDYT@werwolf666?