Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] [Crowdin] Use synchronous HTTP requests when reading the Crowdin API#48109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Translation] [Crowdin] Use synchronous HTTP requests when reading the Crowdin API#48109
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedNov 4, 2022
If the limit is 20 concurrent requests and not 1, we don't need to use synchronous requests. We only need to limit concurrency to 20. |
nicolas-grekas commentedNov 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can you try forcing HTTP/1.1? Because the default is to open max 6 connections the remote hosts. If we hit the 20 limit, it means we're using HTTP/2. If that works, then the fix could be just to force the |
Kocal commentedNov 4, 2022
Thanks for your suggestions, putting a limit of 6 or 20 concurrent requests won't really work in our case, since we pull translations locally, in our CI, and when deploying our app in review apps / staging / production. Putting a limit of 1 would be ideal for us, this way we can be sure that we won't hit the Crowdin's concurrent requests limit across envs. |
stof commentedNov 4, 2022
Maybe the provider should also wrap the client into a RetryableHttpClient |
nicolas-grekas commentedNov 4, 2022
Can you still give it a try? 3x6 = 18 so that might work. |
nicolas-grekas commentedNov 5, 2022
Closing as we're likely not going with this approach. Please let us know if force http 1.1 is enough in practice. |
Kocal commentedNov 5, 2022
Yeah I gonna try to force HTTP 1.1, or playing with max host connections option ASAP |
Uh oh!
There was an error while loading.Please reload this page.
Hi!
We are migrating to Crowdin and we faced
429 Too Many Requests issueswhen pull translations, because we have a lot of locales and domains in our application, andCrowdin limits 20 parallel requests per account.This is like#44416, but for Crowdin :)
Thanks.