Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Remove special case for#[IsGranted()] subject#48102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
chalasr merged 1 commit intosymfony:6.2fromHypeMC:make-request-always-available-to-isgranted-2Nov 4, 2022
Merged
[Security] Remove special case for#[IsGranted()] subject#48102
chalasr merged 1 commit intosymfony:6.2fromHypeMC:make-request-always-available-to-isgranted-2Nov 4, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
HypeMC commentedNov 3, 2022
| useSymfony\Component\HttpKernel\Exception\HttpException; | ||
| useSymfony\Component\HttpKernel\HttpKernelInterface; | ||
| useSymfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface; | ||
| useSymfony\Component\Security\Core\Authorization\ExpressionLanguage; |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a mistake I made in my original PR#46978
stof approved these changesNov 4, 2022
chalasr approved these changesNov 4, 2022
Thank you@HypeMC. |
fabpot added a commit to symfony/symfony-docs that referenced this pull requestMar 24, 2023
… (HypeMC)This PR was merged into the 6.2 branch.Discussion----------[Security] Use expression for `#[IsGranted()]` subjectsymfony/symfony#46978symfony/symfony#48080symfony/symfony#48102Commits-------9d4045f [Security] Use expression for #[IsGranted()] subject
weaverryan pushed a commit to symfony/symfony-docs that referenced this pull requestMar 28, 2023
… (HypeMC)This PR was merged into the 6.2 branch.Discussion----------[Security] Use expression for `#[IsGranted()]` subjectsymfony/symfony#46978symfony/symfony#48080symfony/symfony#48102Commits-------9d4045f [Security] Use expression for #[IsGranted()] subject
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a comment by@stof
Instead of having
requestas a special case, an expression can be used instead: