NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] Stream timeout not detected fgets returns false#48075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromSezil:issue-48074

Nov 4, 2022

Merged

[Mailer] Stream timeout not detected fgets returns false#48075

fabpot merged 1 commit intosymfony:4.4fromSezil:issue-48074

Nov 4, 2022

Conversation

Copy link

Contributor

Sezil commentedNov 2, 2022

#48074 [Mailer] Stream timeout not detected due to checking only string result of function fgets

Q	A
Branch?	6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes
Bug fix?	yes/no
New feature?	yes/no
Deprecations?	yes/no
Tickets	Fix #...
License	MIT
Doc PR	symfony/symfony-docs#...

carsonbot added Status: Needs Review Bug Deprecation Feature Mailer labels

Nov 2, 2022

carsonbot added this to the5.4 milestone

Nov 2, 2022

Copy link

carsonbot commentedNov 2, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedNov 2, 2022

Hey!

Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes ".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot