Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Check IPv6 is valid before comparing it#48050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
chalasr approved these changesOct 31, 2022
fabpot approved these changesNov 1, 2022
Member
fabpot commentedNov 1, 2022
Thank you@PhilETaylor. |
Merged
This was referencedNov 28, 2022
Merged
Merged
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
fabpot added a commit that referenced this pull requestDec 9, 2022
…jected (bonroyage)This PR was squashed before being merged into the 5.4 branch.Discussion----------[HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#48420 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License | MITI've based it on 4.4 because that's where#48050 was merged into, but I guess I'm 1 day too late with a fix for that versionCommits-------2170d3c [HttpFoundation] IPv4-mapped IPv6 addresses incorrectly rejected
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the
checkIp6only validates IPv6 addresses and ipv6 subnets.PR Assumes that IPv6 and ipv6 subnets can never have a period in them (which as far as I know, is correct).