Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Remove redundant code from logger template#48046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@HypeMC
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Introduced in#42195, the log trace gets unnecessarily rendered twice:

image

@carsonbot
Copy link

Hey!

I think@Amunak has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@derrabus
Copy link
Member

@javiereguiluz Can you have a look?

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry I missed this. Thanks for fixing this issue!

@fabpot
Copy link
Member

Thank you@HypeMC.

@fabpotfabpot merged commit68e3261 intosymfony:5.4Dec 1, 2022
@HypeMCHypeMC deleted the remove-redundant-code-from-logger-template branchDecember 1, 2022 22:24
@fabpotfabpot mentioned this pull requestDec 6, 2022
This was referencedDec 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@stofstofstof approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

7 participants

@HypeMC@carsonbot@derrabus@fabpot@javiereguiluz@stof@maxhelias

[8]ページ先頭

©2009-2025 Movatter.jp