Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Deprecate enabling bundle and not configuring it#48043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:6.3fromalamirault:feature/47593-no-security-configuration-trigger-deprecationNov 26, 2022
Merged
[SecurityBundle] Deprecate enabling bundle and not configuring it#48043
fabpot merged 1 commit intosymfony:6.3fromalamirault:feature/47593-no-security-configuration-trigger-deprecationNov 26, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
carsonbot commentedOct 30, 2022
Hey! I think@TimoBakx has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
derrabus approved these changesNov 1, 2022
src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/AliasedEvents/config.yml OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
chalasr approved these changesNov 5, 2022
fabpot approved these changesNov 26, 2022
a08dcc6 toff76d26CompareMember
fabpot commentedNov 26, 2022
Thank you@alamirault. |
Merged
nicolas-grekas added a commit that referenced this pull requestJun 8, 2023
…figuring it is not allowed (alexandre-daubois)This PR was merged into the 7.0 branch.Discussion----------[SecurityBundle] Enabling `SecurityBundle` and not configuring it is not allowed| Q | A| ------------- | ---| Branch? | 7.0| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Removes the code deprecated in#48043Commits-------2388239 [SecurityBundle] Enabling `SecurityBundle` and not configuring it is not allowed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In order to improve DX, add Trigger deprecation when
SecurityBundleis enable without configuration.