Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Split loggers debug compiler pass#48041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.2fromMatTheCat:ticket_48040
Nov 10, 2022

Conversation

@MatTheCat
Copy link
Contributor

QA
Branch?6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#48040
LicenseMIT
Doc PRN/A

As the Monolog and HttpKernel’s loggers have nothing to do with each other I feel like giving each one its own compiler pass is best.

@maxbeckers
Copy link
Contributor

This would be a BC break or am I wrong?

@MatTheCat
Copy link
ContributorAuthor

MatTheCat commentedOct 29, 2022•
edited
Loading

@maxbeckers how? Are compiler passes configurators part of Symfony’s public API?

@maxbeckers
Copy link
Contributor

My two thoughts were renaming the class and changing the priorities. It's only debug compiler passes, but wanted to at least note it. That's why I'm not sure if it's a BC break or not.

MatTheCat reacted with thumbs up emoji

@MatTheCat
Copy link
ContributorAuthor

@fabpot I see you changed the milestone to 6.3 but this PR is supposed to be a fix for a feature introduced in 6.2. Is that alright?

@nicolas-grekasnicolas-grekas modified the milestones:6.3,6.2Nov 5, 2022
@fabpot
Copy link
Member

In that case, 6.2 is indeed the right target.

@nicolas-grekas
Copy link
Member

Thank you@MatTheCat.

@nicolas-grekasnicolas-grekas merged commit4618856 intosymfony:6.2Nov 10, 2022
@MatTheCatMatTheCat deleted the ticket_48040 branchNovember 10, 2022 09:06
@fabpotfabpot mentioned this pull requestNov 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[FrameworkBundle][HttpKernel] Logger debug mode disabled

6 participants

@MatTheCat@maxbeckers@fabpot@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp