The issue rather comes from the factbase_js.html.twig redefinesSfjs ifSfjs.loadToolbar is undefined.

So ifexception.js runs first it will define a version ofSfjs withcreateFilters and noloadToolbar. Problem is, it callscreateFilters onDOMContentLoaded. So whenbase_js.html.twig kicks in, it redefinesSfjs withloadToolbar and nocreateFilters. ThenDOMContentLoaded is triggered and it tries to callcreateFilters.

I don’t even know why there are two flavors ofSfjs?

lol you literally just paraphrased what I had already said :)

I don’t even know why there are two flavors of Sfjs?

I guess you could show exceptions withcomponent/ErrorHandler without theWebProfilerBundle being installed, thusexception.js would be the only code running.

Quite the opposite in fact: you’re sayingbase_js.html.twig is definingSfjs beforeexception.js but it’s wrong because in that casecreateFilters would not be called and there would be no error.

GivencreateFilters targets[data-filters] and the only one exists in the translation collector, I’m not even sure it serves any purpose.

I’m not even sure it serves any purpose.

I did think that, but I like to assume everything in Symfony has a reason to be there and that the code it mostly bug free. Maybe. I assume too much :)

So you would propose to remove calls to this function in theexception.js? In fact I think that's the better solution because<script>Sfjs.createFilters();</script> is called intranslation.html.twig itself.

but it’s wrong because in that case createFilters would not be called and there would be no error.

The calls to the function are outside the "if undefined" block, and so they do get called.

So you would propose to remove calls to this function in the exception.js? In fact I think that's the better solution because <script>Sfjs.createFilters();</script> is called in translation.html.twig itself.

PR updated now to just that change.

IfcreateFilters is only called when it’s not defined it can be removed with all of its invocations and the related markup.

I think every occurrence oftable-filters ortable-filter attributes in HTML or CSS can be removed 🤔

Maybe you could change the PR’s title too!

Friendly ping@PhilETaylor

Friendly ping@PhilETaylor

Thanks. Yup I know I suck :) I have this one and the Doctrine profiler PR to revisit, it's still on my plate to do both. Sorry for the delay.

Closing as this stalled. Please resubmit when you can. Or maybe@MatTheCat if you're up to?

I opened#50108 because we missed the big picture in this PR 😅