Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Fabbot] Addglobal_namespace_import PHPCSFixer rule#48002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
chalasr wants to merge1 commit intosymfony:4.4fromchalasr:global-ns-fabbot

Conversation

@chalasr
Copy link
Member

QA
Branch?4.4
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

As suggested in#47709 (comment)

@carsonbotcarsonbot added this to the4.4 milestoneOct 26, 2022
@chalasrchalasr changed the title[Fabbot] Addglobal_namespace_import PHPCsFixer rule[Fabbot] Addglobal_namespace_import PHPCSFixer ruleOct 26, 2022
@stof
Copy link
Member

Isn't this already part of the@Symfony or@Symfony:risky rulesets ? This is a rule we have since years in the Symfony coding standards.

@chalasr
Copy link
MemberAuthor

Nopehttps://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/doc/ruleSets/Symfony.rst.
Do you think it should? I tend to think it's fine to enable this one only on the core codebase.

@welcoMattic
Copy link
Member

It mentioned inhttps://symfony.com/doc/current/contributing/code/standards.html

Add a use statement for every class that is not part of the global namespace;

But not applied inhttps://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/doc/ruleSets/Symfony.rst?rgh-link-date=2022-10-26T12%3A10%3A34Z

I think we should fix the rule set instead of the core config

@chalasr
Copy link
MemberAuthor

Works for me:PHP-CS-Fixer/PHP-CS-Fixer#6662

@chalasrchalasr deleted the global-ns-fabbot branchOctober 26, 2022 12:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@chalasr@stof@welcoMattic@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp