NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] Fix console`ProgressBar::override()` after manual`ProgressBar::cleanup()`#47998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4frommaxbeckers:patch-47987

Nov 11, 2022

Merged

[Console] Fix console`ProgressBar::override()` after manual`ProgressBar::cleanup()`#47998

fabpot merged 1 commit intosymfony:5.4frommaxbeckers:patch-47987

Nov 11, 2022

Conversation

Copy link

Contributor

maxbeckers commentedOct 26, 2022

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#47987
License	MIT
Doc PR

In the issue#47987 is described, that there is a problem with overriding lines withProgressBar::override() on a multiline console output with manual call ofProgressBar::cleanup().

Testcode:

ProgressBar::setFormatDefinition('normal_nomax', "[%bar%]\n%message%");$progressBar = new ProgressBar($output);$progressBar->setMessage('Processing "foobar"...');$progressBar->start();$progressBar->clear();$output->writeln('Foo!');$progressBar->display();$progressBar->finish();

Output before the fix:

Progress bar having only one line:Foo![----->----------------------]=-=-=-=Progress bar having two lines:[----->----------------------]Processing "foobar"...

Expected output / output after the fix:

Progress bar having only one line:Foo![----->----------------------]=-=-=-=Progress bar having two lines:Foo![----->----------------------]Processing "foobar"...

maxbeckers requested a review fromchalasr as acode owner

October 26, 2022 07:23

carsonbot added Status: Needs Review Bug Console labels

Oct 26, 2022

carsonbot added this to the6.2 milestone

Oct 26, 2022

maxbeckers changed the base branch from6.2 to5.4

October 26, 2022 07:28

Copy link

ContributorAuthor

maxbeckers commentedOct 26, 2022•
edited
Loading

Build failures are unrelated to the change.

Should be added to Milestone 5.4, had the wrong target branch when i created the PR.

Copy link

carsonbot commentedOct 29, 2022

Hey!

I think@CesarScur has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link

ContributorAuthor

maxbeckers commentedNov 4, 2022

To reproduce i added a zip with the fix in vendor:
test-47998.zip
Just runphp testcommand.php in root.

Output without the fix:

Progress bar having only one line:Foo![----->----------------------]=-=-=-=Progress bar having two lines:[----->----------------------]Processing "foobar"...============================foobar

Output with the fix:

Progress bar having only one line:Foo![----->----------------------]=-=-=-=Progress bar having two lines:Foo![----->----------------------]Processing "foobar"...=-=-=-=============================foobar