It's often useful to have the routing key available when decoding messages from AMQP. For example, sometimes the routing key contains meta information required for the processing of the message.

This introduces anextra element which currently only contains the routing key, but there is scope to add other meta information from \AMQPEnvelope such as the exchange name for example.

Fixes#43039

carsonbot added Status: Needs Review Messenger labels

Oct 24, 2022

carsonbot added this to the6.2 milestone

Oct 24, 2022

carsonbot changed the title~~[Messenger][AMQP] Add routing key to data passed to serializer decode.~~[Messenger] [AMQP] Add routing key to data passed to serializer decode.

Oct 24, 2022

jenkoian force-pushed theissue-43039 branch fromac37918 to3bd6fd1Compare

October 24, 2022 14:34

[Messenger][AMQP] Add routing key to data passed to serializer decode.

6a5e2b5

It's often useful to have the routing key available when decodingmessages from AMQP. For example, sometimes the routing key contains metainformation required for the processing of the message.This introduces an `extra` element which currently only contains therouting key, but there is scope to add other meta information from\AMQPEnvelope such as the exchange name for example.Fixessymfony#43039

jenkoian force-pushed theissue-43039 branch from3bd6fd1 to6a5e2b5Compare

October 24, 2022 14:41

nicolas-grekas modified the milestones:6.2,6.3

Nov 5, 2022

Copy link

glengemann commentedDec 3, 2022

Hi! It is possible that you can solve the problem or at least have a workaround using aMiddleware in conjunction with theHandlerArgumentsStamp.

For example, I have a message with some AMQP properties attached:

$message =newDetectFacesMessage($file->getContent());$this->bus->dispatch($message, [newAmqpStamp('detect-faces', attributes: ['content_type' =>'text/plain','correlation_id' =>$uniqid,'reply_to' =>'response-queue',            ]),        ]);

And I need thecontent_type,correlation_id andreply_to AMQP properties in theconsumer in order to perform some logic. Then, my consumer look this way:

publicfunction__invoke(DetectFacesMessage$message,string$replyTo,string$correlationId,string$contentType,string$timestamp,    ) {    }

I have theAMPQ properties as a method parameters because I am using aMiddleware. It reads/gets theAMPQ properties from theAMPQ Envelope. TheMiddleware look like this:

publicfunctionhandle(Envelope$envelope,StackInterface$stack):Envelope    {$amqpStamp =$envelope->last(AmqpReceivedStamp::class);if ($amqpStamp) {$replyTo =$amqpStamp->getAmqpEnvelope()->getReplyTo();$correlationId =$amqpStamp->getAmqpEnvelope()->getCorrelationId();$contentType =$amqpStamp->getAmqpEnvelope()->getContentType();$timestamp =$amqpStamp->getAmqpEnvelope()->getTimestamp();$routingKey =$amqpStamp->getAmqpEnvelope()->getRoutingKey();// Here!$arguments = [$replyTo,$correlationId,$contentType,$timestamp,            ];$envelope =$envelope->with(newHandlerArgumentsStamp($arguments));        }return$stack->next()->handle($envelope,$stack);    }

I think you can get therouting key in this way. Sounds good to you?

Copy link

ContributorAuthor

jenkoian commentedDec 6, 2022

Thanks@glengemann, I'm looking to have the routing key available in the serializer as part of decoding (I need it to work out which message to create based from the routing key). If I've understood correctly, serializer decoding (deserializing) is done before it enter into the bus and thus the middlewares.