Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Filesystem] renameFilesystem::mirror() optioncopy_on_windows tofollow_symlinks#47969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
maxbeckers wants to merge1 commit intosymfony:7.4
base:7.4
Choose a base branch
Loading
frommaxbeckers:patch-25798

Conversation

maxbeckers
Copy link
Contributor

@maxbeckersmaxbeckers commentedOct 24, 2022•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?yes
TicketsFix#25798
LicenseMIT
Doc PRsymfony/symfony-docs#17394
  • submit changes to the documentation

This is a PR for#25798. In the issue is described, that the option copy_on_windows is a bit misleading, because there might be as well other usecases to follow the symlinks like copying to a different drive or a docker context which does not support symlinks.

The old optioncopy_on_windows is marked as deprecated with the hint to use the optionfollow_symlinks, doing interally exactly the same. Just a renaming of the option with making the old one deprecated for no BC breaks.

@maxbeckers
Copy link
ContributorAuthor

Build failures seem to be unrelated to the change.

@maxbeckersmaxbeckers changed the title[Filesystem] rename Filesystem::mirror option copy_on_windows to follow_symlinks[Filesystem] renameFilesystem::mirror() option copy_on_windows to follow_symlinksOct 25, 2022
@carsonbot
Copy link

Hey!

I think@gechetspr has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Contributor

@gechetsprgechetspr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good from my side. One minor comment is IMO nice to have, but it's working fine as it is

@maxbeckersmaxbeckersforce-pushed thepatch-25798 branch 2 times, most recently from4b3f98e tofdcc518CompareJune 5, 2023 08:51
@OskarStarkOskarStark changed the title[Filesystem] renameFilesystem::mirror() option copy_on_windows to follow_symlinks[Filesystem] renameFilesystem::mirror() optioncopy_on_windows tofollow_symlinksJun 5, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.4,7.1Nov 15, 2023
@xabbuhxabbuh modified the milestones:7.1,7.2May 15, 2024
@javiereguiluzjaviereguiluz added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelOct 18, 2024
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@fabpotfabpot removed the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelNov 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@mtarldmtarldmtarld requested changes

@gechetsprgechetsprgechetspr approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@lyrixxlyrixxAwaiting requested review from lyrixx

@dunglasdunglasAwaiting requested review from dunglas

@ycerutoycerutoAwaiting requested review from yceruto

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasr

@jderussejderusseAwaiting requested review from jderusse

Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

[filesystem] copy_on_windows option for mirror() is misleading
9 participants
@maxbeckers@carsonbot@OskarStark@mtarld@gechetspr@fabpot@javiereguiluz@nicolas-grekas@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp