Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security][Serializer] Add missing args to trigger_deprecation#47955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.4fromalamirault:hotfix/fix-trigger-deprecation-argsOct 23, 2022
Merged
[Security][Serializer] Add missing args to trigger_deprecation#47955
fabpot merged 1 commit intosymfony:5.4fromalamirault:hotfix/fix-trigger-deprecation-argsOct 23, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
22d7e07 to2d3bf8cCompareMember
derrabus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catches!
src/Symfony/Component/Security/Core/Authorization/AuthorizationChecker.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
derrabus approved these changesOct 22, 2022
chalasr approved these changesOct 22, 2022
fabpot approved these changesOct 23, 2022
699c3e3 to1114ea8CompareMember
fabpot commentedOct 23, 2022
Good catch, thanks@alamirault. |
This was referencedOct 28, 2022
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that an argument was missing to
trigger_deprecationin AuthorizationChecker. Found other places with this problem.