Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] Add support for "friendsofphp/well-known-implementations"#47950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
stof approved these changesOct 21, 2022
kbond approved these changesOct 22, 2022
fabpot approved these changesOct 22, 2022
Thank you@nicolas-grekas. |
Merged
nicolas-grekas added a commit that referenced this pull requestFeb 10, 2023
…mplementations" (nicolas-grekas)This PR was merged into the 6.2 branch.Discussion----------[HttpClient] Revert support for "friendsofphp/well-known-implementations"| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -This reverts PR#47950The major features of "friendsofphp/well-known-implementations" are now available in "php-http/discovery" [v1.15.0](https://github.com/php-http/discovery/releases/tag/1.15.0), see:-php-http/discovery#209-php-http/discovery#208Given the extremely low download stats of "friendsofphp/well-known-implementations", I propose to just remove support for it as a bugfix:https://packagist.org/packages/friendsofphp/well-known-implementationsThis will save us from maintaining this integration, which is unused code in practice anyway.Commits-------081aa00 Revert "[HttpClient] Add support for "friendsofphp/well-known-implementations""
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seehttps://github.com/FriendsOfPHP/well-known-implementations for what this is about.
This provides an alternative auto-discovery mechanism to php-http/discovery.