Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config][Routing] Nicer config syntax for PSR-4 route loading#47943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedOct 21, 2022
@derrabus thanks for taking the time to update the config syntax of this feature 🙏 |
6ae58f7 to94f0b72Comparesrc/Symfony/Component/Routing/Loader/schema/routing/routing-1.0.xsd OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
5328cf2 to82b3b74Compare82b3b74 tod7df3beComparefabpot commentedOct 22, 2022
Thank you@derrabus. |
fabpot commentedOct 22, 2022
symfony/recipes#1138 for the recipe update. |
| if ($loaderinstanceof self &&null !==$this->currentDir) { | ||
| if (!$loaderinstanceof self) { | ||
| return$loader->load($resource,$type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@derrabus That does not work as the PSR-4 loader uses the locator but without the current dir, so the resource cannot be found. Or am I missing something?
…irectory (derrabus)This PR was merged into the 6.2 branch.Discussion----------[Config][Routing] Fix delegating to PSR-4 loader from subdirectory| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#47943 (comment)| License | MIT| Doc PR | N/ACommits-------c1f0ccb Fix delegating to PSR-4 loader from subdirectory
…iles (derrabus)This PR was merged into the 6.2 branch.Discussion----------[Routing] Add tests for loading PSR-4 classes from PHP files| Q | A| ------------- | ---| Branch? | 6.2| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | N/A| License | MIT| Doc PR | N/AFollow-up to#47916,#47943This PR adds more tests, demonstrating how to trigger the new PSR-4 loader from a PHP config file.Commits-------416639c Add tests for loading PSR-4 classes from PHP files
This PR implements an alternative syntax for the PSR-4 route loader introduced in#47916.