Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Intl] Update the ICU data to 72.1 - 5.4#47918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromjderusse:icu721-54
Oct 20, 2022

Conversation

@jderusse
Copy link
Member

@jderussejderusse commentedOct 19, 2022•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets/
LicenseMIT
Doc PR/

@carsonbot

This comment was marked as outdated.

@jderussejderusse marked this pull request as ready for reviewOctober 19, 2022 14:48
@carsonbotcarsonbot added this to the5.4 milestoneOct 19, 2022
@jderusse
Copy link
MemberAuthor

In previous versions, we also patched the oldest maintained branch (aka 4.4). Seehttps://github.com/symfony/symfony/pulls?q=is%3Apr+icu+author%3Ajderusse+is%3Aclosed

But this branch still use thejson format, which required a second BIG PR and merge conflicts.

Given 4.4 is soon EOL, should I open a second PR for ICU 72.1?

@fabpot
Copy link
Member

I'm okay with not updating 4.4.

@fabpot
Copy link
Member

Thank you@jderusse.

@fabpotfabpot merged commit7616c8d intosymfony:5.4Oct 20, 2022
@jderussejderusse deleted the icu721-54 branchOctober 20, 2022 07:36
This was referencedOct 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@jderusse@carsonbot@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp