Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Update Application.php#47907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromaleksandr-shevchenko:patch-1
Oct 26, 2022

Conversation

@aleksandr-shevchenko
Copy link
Contributor

@aleksandr-shevchenkoaleksandr-shevchenko commentedOct 19, 2022
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

#47862 (comment)

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh
Copy link
Member

Should this be merged into the4.4 branch?

@aleksandr-shevchenko
Copy link
ContributorAuthor

Should this be merged into the4.4 branch?

Do what you think is right.

@nicolas-grekasnicolas-grekas modified the milestones:6.2,4.4Oct 19, 2022
@carsonbotcarsonbot changed the titleUpdate Application.php[Console] Update Application.phpOct 19, 2022
@nicolas-grekasnicolas-grekas changed the base branch from6.2 to4.4October 19, 2022 07:50
@nicolas-grekasnicolas-grekas changed the base branch from4.4 to6.2October 19, 2022 07:50
@xabbuh
Copy link
Member

Will the error output look differently after this change? If so, can you share before and after screenshots?

@aleksandr-shevchenko
Copy link
ContributorAuthor

Will the error output look differently after this change? If so, can you share before and after screenshots?

image

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM then

@xabbuh
Copy link
Member

@maxbeckers what do you think?

@maxbeckers
Copy link
Contributor

@xabbuh im also fine with that. 👍

@nicolas-grekas
Copy link
Member

@aleksandr-shevchenko can you please submit the PR for 4.4? The code is not exactly the same.
Please mind the commit message/PR title also since this is going to be used for the changelog.
Thanks.

@maxbeckers
Copy link
Contributor

@nicolas-grekas the difference in 4.4 is from PR#47883 ... so i guess it shoud be rebased to 4.4 and then merged to 4.4?

@nicolas-grekas
Copy link
Member

yes

@fabpot
Copy link
Member

Is anyone willing to submit this change to 4.4?

@maxbeckers
Copy link
Contributor

I'd do that, but I guess I only could create a new PR with the change. So@aleksandr-shevchenko should do the rebase.

@xabbuhxabbuh changed the base branch from6.2 to4.4October 26, 2022 16:02
@xabbuh
Copy link
Member

I did the rebase and switched the target branch to4.4.

@fabpot
Copy link
Member

Thank you@aleksandr-shevchenko.

@fabpotfabpot merged commitb3a0efc intosymfony:4.4Oct 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@wouterjwouterjAwaiting requested review from wouterj

@dunglasdunglasAwaiting requested review from dunglas

+1 more reviewer

@maxbeckersmaxbeckersmaxbeckers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@aleksandr-shevchenko@carsonbot@xabbuh@maxbeckers@nicolas-grekas@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp