NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[DependencyInjection] Add support for tagged iterators/locators exclude option to xml and yaml#47902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.2fromHypeMC:tagged-exclude-with-all-types

Oct 19, 2022

Merged

[DependencyInjection] Add support for tagged iterators/locators exclude option to xml and yaml#47902

nicolas-grekas merged 1 commit intosymfony:6.2fromHypeMC:tagged-exclude-with-all-types

Oct 19, 2022

Conversation

Copy link

Member

HypeMC commentedOct 18, 2022

Q	A
Branch?	6.2
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Followup to#44774 .

The previous PR added support for theexclude option to php attributes & php config files, but not xml or yaml, making it impossible to use this feature with those config types.
Also, since the support for this feature was never added to the yaml & xml dumpers, the generatedApp_KernelDevDebugContainer.xml is actually incorrect (possibly should be considered a bug), eg the following php configuration:

$services->set(TestExclude::class)        ->public()        ->args([tagged_iterator('app.test', exclude: TestExclude::class),        ]);

produces this xml file:

    <serviceid="App\Service\TestExclude"class="App\Service\TestExclude"public="true">      <tagname="app.test"/>      <argumenttype="tagged_iterator"tag="app.test"/>    </service>

With this PR, the dumpers are now aware of theexclude option:

    <service public="true">      <tag name="app.test"/>-     <argument type="tagged_iterator" tag="app.test"/>+     <argument type="tagged_iterator" tag="app.test" exclude="App\Service\TestExclude"/>    </service>

carsonbot added Status: Needs Review DependencyInjection Feature labels

Oct 18, 2022

carsonbot added this to the6.2 milestone

Oct 18, 2022

carsonbot changed the title~~[DI] Add support for tagged iterators/locators exclude option to xml and yaml~~[DependencyInjection] Add support for tagged iterators/locators exclude option to xml and yaml

Oct 18, 2022