Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Remove EOL when using error_log() in HttpKernel Logger#47878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromcyve:remove-eol-error-log
Oct 18, 2022

Conversation

@cyve
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?maybe
Tickets
LicenseMIT
Doc PR

Hello there !

Since PR#36855, when usingSymfony\Component\HttpKernel\Log\Logger with argument$output = null. The logger use theerror_log() method to log messages. But in the log file, messages are separated by an empty line because the default formatter (Logger::format()) adds an extra EOL char at the end of the message.

This fix prevents the logger to add an extra EOL char when it useserror_log().

Possible BC : if someone use the logger with a custom formatter that already add a EOL char at the end of the message, there will be a empty line between messages in the log file. In my opinion, this is minor enough not to worry about it ;-)

Thanks for your review :-)

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@cyvecyveforce-pushed theremove-eol-error-log branch 2 times, most recently fromd6de97d to051e16cCompareOctober 16, 2022 16:47
@cyve
Copy link
ContributorAuthor

Hi, I added a 2nd commit to apply coding standards on code that was not modified by the PR itself. Should I squash them ?

@nicolas-grekas
Copy link
Member

Thank you@cyve.

@nicolas-grekasnicolas-grekas merged commit323c713 intosymfony:4.4Oct 18, 2022
This was referencedOct 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@cyve@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp