Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Deprecation Contracts Dependency#47873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:6.2fromMGatner:patch-1
Oct 15, 2022

Conversation

@MGatner
Copy link
Contributor

QA
Branch?6.2 (branch follow-up)
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR

I believeca3a246 addeddeprecation-contracts to the incorrect field, which is causing the actual package not to install in some circumstances because it thinks HTTPClient provides the dependency.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

MGatner reacted with heart emoji

@carsonbotcarsonbot changed the titleDeprecation Contracts Dependency[HttpClient] Deprecation Contracts DependencyOct 15, 2022
@derrabus
Copy link
Member

Good catch, thanks@MGatner.

@derrabusderrabus merged commit889f4d6 intosymfony:6.2Oct 15, 2022
@MGatner
Copy link
ContributorAuthor

💪

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@MGatner@carsonbot@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp