Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Fix empty request stack when terminating with exception#47857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromkrzyc:ticket_47577
Oct 18, 2022

Conversation

@krzyc
Copy link
Contributor

QA
Branch?4.4, 5.4, 6.0, 6.1, 6.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#47577
LicenseMIT
Doc PR

After#47358 the RequestStack is empty when request terminates with exception, which prevents SecurityDataCollector to generate logout URL and generates fatal error.

dmaicher, Chris53897, alioguz, and 7ochem reacted with thumbs up emojiKocal, alioguz, and 7ochem reacted with heart emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@VincentLanglet
Copy link
Contributor

VincentLanglet commentedOct 18, 2022•
edited
Loading

I got the issue locally (on SF 6.1) and I can confirm this PR is fixing the issue.

lowwa132 reacted with thumbs up emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I added a check to make the logic work in case of re-injected fatal errors (which means the request won't have had the opportunity to be popped)

@nicolas-grekas
Copy link
Member

Thank you@krzyc.

krzyc, Chris53897, lowwa132, and alioguz reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@krzyc@carsonbot@VincentLanglet@nicolas-grekas@stof
[8]ページ先頭
©2009-2025 Movatter.jp