Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Routing] Fix TypeError when using UrlGenerator#47856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
apollisa wants to merge1 commit intosymfony:5.4fromapollisa:ticket_47844
Closed

[Routing] Fix TypeError when using UrlGenerator#47856

apollisa wants to merge1 commit intosymfony:5.4fromapollisa:ticket_47844

Conversation

@apollisa
Copy link

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#47844
LicenseMIT

This fixes bug#47844, based ona suggestion from@stof.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Router] Fix TypeError when using UrlGenerator[Routing] Fix TypeError when using UrlGeneratorOct 13, 2022
@stof
Copy link
Member

Duplicate of#47855

@stofstof marked this as a duplicate of#47855Oct 13, 2022
@javiereguiluz
Copy link
Member

Thanks for your contribution@apollisa, but as@stof said, this is a duplicate of another PR which was sent earlier, so let's close this in favor of the other one. Cheers.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@apollisa@carsonbot@stof@javiereguiluz

[8]ページ先頭

©2009-2025 Movatter.jp