Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] TypeError in Router when using UrlGenerator#47855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4frommaxbeckers:patch-47844
Oct 15, 2022

Conversation

@maxbeckers
Copy link
Contributor

@maxbeckersmaxbeckers commentedOct 13, 2022•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#47844
LicenseMIT
Doc PR

Fix the array_merge problem when using theUrlGenerator and not theCompiledUrlGenerator. For more details about the bug see the issue#47844

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@maxbeckersmaxbeckers changed the base branch from6.2 to5.4October 13, 2022 14:15
@maxbeckers
Copy link
ContributorAuthor

Milestone should be moved to 5.4

@stofstof modified the milestones:6.2,5.4Oct 13, 2022
@maxbeckers
Copy link
ContributorAuthor

Test failures seem to be not related to my changes.

@fabpot
Copy link
Member

Thank you@maxbeckers.

maxbeckers reacted with thumbs up emoji

@fabpotfabpot merged commit6a96afd intosymfony:5.4Oct 15, 2022
This was referencedOct 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

TypeError in Router when using UrlGenerator

6 participants

@maxbeckers@carsonbot@fabpot@stof@xabbuh@yceruto
[8]ページ先頭
©2009-2025 Movatter.jp